Add support for Ulimit in quadlet#19956
Add support for Ulimit in quadlet#19956openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
"Use" to "Using", or "will modify" to "to modify". I'd keep "Use"
pkg/systemd/quadlet/quadlet.go
Outdated
There was a problem hiding this comment.
Please move the correct place in the alphabetical order
pkg/systemd/quadlet/quadlet.go
Outdated
There was a problem hiding this comment.
Please move the correct place in the alphabetical order
pkg/systemd/quadlet/quadlet.go
Outdated
There was a problem hiding this comment.
| ulimit, _ := container.Lookup(ContainerGroup, KeyUlimit) | |
| if len(ulimit) > 0 { | |
| podman.add("--ulimit", ulimit) | |
| } | |
| ulimit, ok := container.Lookup(ContainerGroup, KeyUlimit) | |
| if ok && len(ulimit) > 0 { | |
| podman.add("--ulimit", ulimit) | |
| } |
openshift-merge-robot
added
the
needs-rebase
QM needs to be able to specify the maximum number of open files within the QM environment to ensure FFI. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
openshift-merge-robot
removed
the
needs-rebase
|
@martinpitt Any idea why all of the cockpit tests are blowing up? |
|
@rhatdan Yes I do, see #19953 (comment) -- it's a testing farm issue, we've discussed that since Wednesday. I'll send a hack to cockpit-podman now to counteract TF's bad hack, that'll clear them up. Sorry about that, growing pains from new things.. |
|
@rhatdan Sorry, I meant see this comment: #19962 (comment) Anyway, testing a workaround now in cockpit-project/cockpit-podman#1410 , should land in about 4 hours. |
github-actions
bot
added
the
locked - please file new issue/PR
6 participants
QM needs to be able to specify the maximum number of open files within the QM environment to ensure FFI.
Does this PR introduce a user-facing change?