Add Intel RDT support#20150
Merged
openshift-merge-robot merged 6 commits intocontainers:mainfrom Sep 28, 2023
Merged
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mheon
reviewed
Sep 26, 2023
mheon
reviewed
Sep 26, 2023
wpross
force-pushed
the
add-rdt
branch
3 times, most recently
from
f87a160 to
4d7363c
Compare
Member
|
Code LGTM |
Member
|
Can you rebase? I think the system test failure is fixed upstream |
Add --rdt-class=COS to the create and run command to enable the assignment of a container to a Class of Service (COS). The COS represents a part of the cache based on the Cache Allocation Technology (CAT) feature that is part of Intel's Resource Director Technology (Intel RDT) feature set. By assigning a container to a COS, all PID's of the container have only access to the cache space defined for this COS. The COS has to be pre-configured based on the resctrl kernel driver. cat_l2 and cat_l3 flags in /proc/cpuinfo represent CAT support for cache level 2 and 3 respectively. Signed-off-by: Wolfgang Pross <wolfgang.pross@intel.com>
Signed-off-by: Wolfgang Pross <wolfgang.pross@intel.com>
Signed-off-by: Wolfgang Pross <wolfgang.pross@intel.com>
Signed-off-by: Wolfgang Pross <wolfgang.pross@intel.com>
Signed-off-by: Wolfgang Pross <wolfgang.pross@intel.com>
Co-authored-by: Tom Sweeney <tsweeney@redhat.com> Signed-off-by: wpross <wolfgang.pross@intel.com>
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, wpross The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Author
|
Thanks @mheon, @TomSweeneyRedHat & @flouthoc for the reviews! |
Member
|
I've opened a PR to add support for Intel RDT to crun: containers/crun#1323 |
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #19922
Support for assigning a container to a Class Of Service (COS) based on
--rdt-class=COSis added. The COS represents a part of the cache based on the Cache Allocation Technology (CAT) feature that is part of Intel's Resource Director Technology (Intel RDT) feature set. By assigning a container to a COS, all PID's of the container have only access to the cache space defined for this COS.The COS has to be pre-configured based on the resctrl kernel driver. This is only possible if the HW supports the CAT feature which can be checked based on the presence of the
cat_l2andcat_l3flags in/proc/cpuinfo.So far, Intel RDT support is only integrated into runc and not in crun yet.
Does this PR introduce a user-facing change?
yes