feat: add --ignore flag to network rm#28391
Open
kyounghunJang wants to merge 1 commit intocontainers:mainfrom
Open
feat: add --ignore flag to network rm#28391kyounghunJang wants to merge 1 commit intocontainers:mainfrom
kyounghunJang wants to merge 1 commit intocontainers:mainfrom
Conversation
github-actions
bot
added
the
kind/api-change
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Honny1
requested changes
Mar 27, 2026
Member
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
Thanks, I have some comments. Also, please fill release note.
lsm5
reviewed
Mar 27, 2026
Member
lsm5
left a comment
lsm5
left a comment
There was a problem hiding this comment.
could you please add a system test to test/system/500-networking.bats ? See the pre-existing tests in that file for network rm .
Member
kyounghunJang
force-pushed
the
feat/add-rm-ignore
branch
from
a48a79c to
cbb6c26
Compare
Contributor
Author
Member
|
I think CI failure is unrelated. |
lsm5
requested changes
Apr 6, 2026
Member
lsm5
left a comment
lsm5
left a comment
There was a problem hiding this comment.
test name should mention --ignore.
test/system/500-networking.bats
Outdated
| } | ||
|
|
||
| # bats test_tags=ci:parallel | ||
| @test "podman network rm -- bogus" { |
Member
There was a problem hiding this comment.
Suggested change
| @test "podman network rm -- bogus" { | |
| @test "podman network rm --ignore bogus" { |
Contributor
Author
There was a problem hiding this comment.
@lsm5
Thank you for catching my mistake!
Add `--ignore` to `podman network rm` so removing a missing network returns success instead of exit code 1. Keep existing error behavior for networks in use and other failures. This commit message was translated from Korean to English using an LLM. Fixes: containers#28363 Signed-off-by: KyounghoonJang <matkimchi_@naver.com>
kyounghunJang
force-pushed
the
feat/add-rm-ignore
branch
from
cbb6c26 to
594309f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--ignoretopodman network rmso removing a missing network returns success instead of exit code 1.Keep existing error behavior for networks in use and other failures.
Example result on macOS:
$ podman network rm --ignore bogus-netThis PR was translated from Korean to English using an LLM.
Fixes: #28363
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?