Skip to content

ci/cd: fix libkrun issue Internal(Vm)#959

Closed
dougsland wants to merge 1 commit intomainfrom
testcicd
Closed

ci/cd: fix libkrun issue Internal(Vm)#959
dougsland wants to merge 1 commit intomainfrom
testcicd

Conversation

@dougsland
Copy link
Copy Markdown
Member

@dougsland dougsland commented Jan 21, 2026

resolve #960

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jan 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request modifies the qm.container file, but the provided diff shows no concrete content changes; it appears to be a no-op or placeholder CI/CD test change.

File-Level Changes

Change Details Files
No functional or content changes are introduced; the commit appears to only touch qm.container for CI/CD testing purposes.
  • No additions, deletions, or modifications to the contents of qm.container are visible in the diff
  • Likely tests repository wiring or CI/CD triggers without altering behavior
qm.container

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @dougsland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request seems to be a functional test for the continuous integration and continuous deployment (CI/CD) pipeline. The changes are minimal and non-functional, involving a simple modification to a comment within a configuration file, likely to trigger and validate the automated build and deployment processes.

Highlights

  • CI/CD Testing: This pull request appears to be a test for the CI/CD pipeline, indicated by the PR title and the nature of the changes.
  • Minor Comment Update: A non-functional comment in the qm.container file has been updated by adding 'test - ' to an existing line.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be for testing the CI/CD pipeline, as it only adds the word 'test' to a comment in the qm.container file. While this change is benign, it's generally not good practice to merge test-specific modifications into the main codebase. My review includes a comment to revert this change to maintain code cleanliness.

Comment thread qm.container Outdated
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Yarboa
Copy link
Copy Markdown
Collaborator

Yarboa commented Jan 22, 2026

Please tak a look here
https://github.com/containers/qm/blob/main/tests/qm-kvm-test/libkrun/check_libkrun.sh#L6

the setup script already enable the repo.
libkrun rpms exist in fedora repo.

So i think the method should query

if grep -qi "^ID=centos" /etc/os-release; <call the method>; fi

@dougsland dougsland force-pushed the testcicd branch 5 times, most recently from 2ecc618 to ef30ca8 Compare January 23, 2026 16:56
@Yarboa
Copy link
Copy Markdown
Collaborator

Yarboa commented Jan 24, 2026

I tried to run locally on my fedora, need to check what has changes in latest packages

podman run --runtime=krun --privileged --device /dev/kvm --security-opt label=disable --ipc=host --rm -it alpine echo 'Hello libkrun.'
[2026-01-24T16:29:50Z ERROR krun] Building the microVM failed: Internal(Vm(SetMemoryAttributes(Error(22))))
{"msg":"exec container process failed with handler as `krun`: Invalid argument","level":"error","time":"2026-01-24T16:29:50.829897Z"}

I do not find --runtime in man podman run

@Yarboa
Copy link
Copy Markdown
Collaborator

Yarboa commented Jan 25, 2026

I think it is a kvm version mismatch for higher kernel version
containers/libkrun#519

Comment thread tests/qm-kvm-test/libkrun/check_libkrun.sh Outdated
Comment thread tests/qm-kvm-test/libkrun/check_libkrun.sh
@dougsland dougsland changed the title [test] testing ci/cd ci/cd: fix libkrun issue Internal(Vm) Jan 26, 2026
@dougsland dougsland force-pushed the testcicd branch 7 times, most recently from 5ac3a2f to 1a49fa1 Compare January 26, 2026 20:55
fixes Internal(Vm(SetMemoryAttributes(Error(22)))) issue.
libkrun 1.17 includes the issue but currently it's in rawhide only.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland
Copy link
Copy Markdown
Member Author

Not needed for now, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/tests/qm-kvm-test/libkrun/check_libkrun failed on fedora-42-x86_64

2 participants