Feat: crJSON and Builder archive updates#108
Open
redaranj wants to merge 3 commits into
Open
Conversation
Set c2paVersion=v0.90.0 in library/gradle.properties. All FFI functions the JNI bridge calls are present in the 0.90.0 header with unchanged signatures; the functions 0.90.0 removes were already migrated off.
Add Reader.crJSON() over c2pa_reader_crjson, alongside json() and detailedJson(), wired through the JNI bridge. Includes shared and Android instrumented tests.
Route nativeFromArchive through c2pa_builder_from_context and c2pa_builder_with_archive, which replace c2pa_builder_from_archive in c2pa-rs 0.90.0. The Kotlin API is unchanged.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
============================================
- Coverage 72.25% 72.21% -0.04%
Complexity 38 38
============================================
Files 62 62
Lines 2346 2350 +4
Branches 284 286 +2
============================================
+ Hits 1695 1697 +2
- Misses 494 495 +1
- Partials 157 158 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds Reader.crJSON() to return the new manifest JSON export format. Migrates Builder.fromArchive to the context-based API. Bumps c2pa-rs version to v0.90.0.
Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment