Skip to content

feat: finish up segment work #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
George Chios (rusticpenguin) wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: finish up segment work #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a13019
feat: finish up segment work
rusticpenguin Apr 19, 2024
6de3dad
fix exports
rusticpenguin Apr 19, 2024
b215fa6
fix test
rusticpenguin Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sdks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export { sentryMarketplaceAppsSDK } from './sentry/sentryMarketplaceAppsSDK';
export { SegmentAnalyticsProvider } from './segment/SegmentMarketplaceProvider';
export { SegmentAnalyticsContext } from './segment/segmentMarketplaceContext';
export { Action as ConfigAction } from './segment/typewriter/segment';
export { ConfigActionAction as ConfigAction } from './segment/typewriter/segment';
12 changes: 6 additions & 6 deletions src/sdks/segment/SegmentMarketplaceProvider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useSDK } from '@contentful/react-apps-toolkit';
import { SegmentAnalyticsContext } from './segmentMarketplaceContext';
import { SegmentAnalyticsProvider } from './SegmentMarketplaceProvider';
import getUserCookieConsent from './utils/getUserCookieConsent';
import typewriter, { Action } from './typewriter/segment';
import typewriter, { ConfigActionAction as Action } from './typewriter/segment';

jest.mock('./utils/getUserCookieConsent');
jest.mock('@contentful/react-apps-toolkit');
Expand All @@ -27,7 +27,7 @@ describe('SegmentAnalyticsProvider', () => {
identify: jest.fn(),
});
mockGetUserCookieConsent.mockReturnValue(true);
mockTypewriter.configSaved = jest.fn();
mockTypewriter.configAction = jest.fn();
mockUseSDK.mockReturnValue({
ids: {
environment: 'test',
Expand All @@ -44,7 +44,7 @@ describe('SegmentAnalyticsProvider', () => {
return (
<button
onClick={() => {
trackEvent('configSaved', {
trackEvent('configAction', {
action: Action.Cancelled,
app_key: 'a',
environment_key: 'b',
Expand All @@ -68,7 +68,7 @@ describe('SegmentAnalyticsProvider', () => {
fireEvent.click(getByText('Test Button'));

await waitFor(() =>
expect(mockTypewriter.configSaved).toHaveBeenCalledWith({
expect(mockTypewriter.configAction).toHaveBeenCalledWith({
action: Action.Cancelled,
app_key: 'a',
environment_key: 'b',
Expand All @@ -86,7 +86,7 @@ describe('SegmentAnalyticsProvider', () => {
return (
<button
onClick={() => {
trackEvent('configSaved', {
trackEvent('configAction', {
action: Action.Cancelled,
app_key: 'a',
environment_key: 'b',
Expand All @@ -109,6 +109,6 @@ describe('SegmentAnalyticsProvider', () => {

fireEvent.click(getByText('Test Button'));

await waitFor(() => expect(mockTypewriter.configSaved).not.toHaveBeenCalled());
await waitFor(() => expect(mockTypewriter.configAction).not.toHaveBeenCalled());
});
});
Loading