fix: overhaul packaging of production build#74
Draft
Lillian Bitner (lilbitner) wants to merge 2 commits into
Draft
fix: overhaul packaging of production build#74Lillian Bitner (lilbitner) wants to merge 2 commits into
Lillian Bitner (lilbitner) wants to merge 2 commits into
Conversation
Lillian Bitner (lilbitner)
force-pushed
the
fix/adjust-packaging
branch
from
May 17, 2024 13:41
1db4a92 to
786f6a6
Compare
Lillian Bitner (lilbitner)
changed the title
Lillian Bitner (lilbitner)
force-pushed
the
fix/adjust-packaging
branch
2 times, most recently
from
May 20, 2024 16:48
3e25b6b to
4544daa
Compare
Lillian Bitner (lilbitner)
force-pushed
the
fix/adjust-packaging
branch
from
May 20, 2024 18:20
4544daa to
9b27f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to essentially overhaul how we are currently package the library.
Please see this document on more explanation on 1. why we are doing this and 2. how to move forward with this PR.
TO DO:
Resolve current build error with an incompatible testing directory. Either resolve this by adjusting the jest config or completely migrate from
create-react-appbased configuration (react-scriptsetc) tovitest.Breaking Changes
tsconfigsneed to be adjusted first (as described in the document).