Skip to content

Added Branches support in entry variants#361

Merged
OMpawar-21 merged 6 commits into
developmentfrom
enh/DX-7322
Jul 24, 2026
Merged

Added Branches support in entry variants#361
OMpawar-21 merged 6 commits into
developmentfrom
enh/DX-7322

Conversation

@sunil-lakshman

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
98.89% (+0.13% 🔼)
984/995
🟢 Branches
96.44% (+0.49% 🔼)
298/309
🟢 Functions
97.77% (+0.01% 🔼)
219/224
🟢 Lines
99.36% (+0.13% 🔼)
937/943

Test suite run success

708 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 40256be

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

harshitha-cstk
harshitha-cstk previously approved these changes May 15, 2026
cs-raj
cs-raj previously approved these changes May 15, 2026
reeshika-h
reeshika-h previously approved these changes May 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Delivery SDK’s entry variant support to optionally include a branch name, allowing variant-scoped requests to also set the branch request header (while keeping existing variants(uid|uids) behavior backward compatible).

Changes:

  • Added buildVariantRequestHeaders() utility to centrally construct x-cs-variant-uid and optional branch headers.
  • Updated Entry, Entries, BaseQuery, and Query request flows to attach variant+branch headers when configured.
  • Added/expanded unit tests and introduced an API test suite covering variant+branch behavior; bumped version + changelog and updated the version-bump workflow to parse the changelog format.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/unit/utils.spec.ts Adds unit coverage for buildVariantRequestHeaders().
test/unit/entry.spec.ts Adds unit coverage for Entry.variants(variant, branch) and fetch header behavior.
test/unit/entries.spec.ts Adds unit coverage for Entries.variants(..., branch) and query().find() header behavior.
test/unit/base-query.spec.ts Extends BaseQuery test harness to include variants branch and validates headers.
test/api/entry-variants-branch.spec.ts New API test suite for entry/entries variant+branch behavior and chaining scenarios.
src/query/query.ts Extends Query to carry variants branch state and apply headers during find().
src/query/base-query.ts Applies shared variant+branch header building in BaseQuery find().
src/entries/entry.ts Adds optional branch argument to Entry.variants() and applies headers during fetch().
src/entries/entries.ts Adds optional branch argument to Entries.variants(), propagates branch into query(), and applies headers during find().
src/common/utils.ts Introduces buildVariantRequestHeaders() helper.
package.json Bumps SDK version to 5.3.0.
package-lock.json Updates lockfile version metadata to 5.3.0.
CHANGELOG.md Adds 5.3.0 entry documenting variant+branch support.
.github/workflows/check-version-bump.yml Updates changelog parsing to support the current “### Version:” format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/entries/entry.ts
Comment thread src/entries/entries.ts
Comment thread src/query/query.ts
… clarity; enhance constructor overloads in Query class
@reeshika-h
reeshika-h dismissed stale reviews from cs-raj, harshitha-cstk, and themself via 7282338 July 20, 2026 06:28
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@OMpawar-21
OMpawar-21 marked this pull request as ready for review July 24, 2026 12:32
@OMpawar-21
OMpawar-21 requested a review from a team as a code owner July 24, 2026 12:32
@OMpawar-21
OMpawar-21 merged commit fb74608 into development Jul 24, 2026
10 checks passed
@OMpawar-21
OMpawar-21 deleted the enh/DX-7322 branch July 24, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants