Skip to content

[DX-2775], fix duplicate modular block Type Definitions #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs-raj merged 3 commits into from
Apr 23, 2025
Merged

[DX-2775], fix duplicate modular block Type Definitions #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
698ae4c
[DX-2775], fix duplicate modular block Type Definitions
Apr 23, 2025
9d915e7
[DX-2775], version bump patch
Apr 23, 2025
ac6eef1
[DX-2775], rollup update
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 86 additions & 86 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contentstack/types-generator",
"version": "2.3.1",
"version": "2.3.2",
"description": "Contentstack type definition generation library",
"private": false,
"author": "Contentstack",
Expand Down Expand Up @@ -38,7 +38,7 @@
"dotenv": "^16.4.7",
"jest": "^29.7.0",
"nock": "^13.5.6",
"rollup": "^4.38.0",
"rollup": "^4.40.0",
"ts-jest": "^29.3.1",
"tsup": "^8.4.0",
"typescript": "^5.7.3"
Expand Down
4 changes: 2 additions & 2 deletions src/generateTS/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export default function (userOptions: TSGenOptions) {
let blockInterfaceName = name_type(field.uid);

const blockInterfaces = field.blocks.map((block) => {
const fieldType = block.reference_to
const fieldType = block.reference_to && cachedGlobalFields[name_type(block.reference_to)]
? name_type(block.reference_to)
: visit_fields(block.schema || []);

Expand Down Expand Up @@ -314,7 +314,7 @@ export default function (userOptions: TSGenOptions) {

// Store or track the generated block interface for later use
modularBlockInterfaces.add(modularInterface);

cachedModularBlocks[blockInterfaceName] = blockInterfaceName;
return field.multiple ? `${blockInterfaceName}[]` : blockInterfaceName;
}

Expand Down
Loading