Merged
Conversation
Document the `Datagrid::$formMethod = 'GET'` option that allows filter values to be reflected in the browser URL, enabling shareable/bookmarkable filter links (e.g. for use in emails). Closes #1074
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
=======================================
Coverage 46.19% 46.19%
=======================================
Files 52 52
Lines 2680 2680
=======================================
Hits 1238 1238
Misses 1442 1442 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datagrid::$formMethod = 'GET'as the solution for sharing filter state via URL (e.g. in emails)filters.mdwith usage example and notes on caveats (static property scope, sensitive data in URL)Closes #1074