updated to latest version of react by creating new proj#27
Open
dunks184 wants to merge 1 commit intoconwaysgame:masterfrom
Open
updated to latest version of react by creating new proj#27dunks184 wants to merge 1 commit intoconwaysgame:masterfrom
dunks184 wants to merge 1 commit intoconwaysgame:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some build errors because the latest version of node has some issue with webpack...
Anyway, I decided to just create a new project with
npx create-react-appand then port the files over. After removing a few redundant dependencies, the app worked.Big Disclaimer: The tests no longer run correctly because there's no official enzyme adapter for react-18 that I could find. Sorry about that. I'm not hugely experienced in testing react apps so I decided to leave that part to you to have a look at.