pyPLUTO now works with datafiles created by PLUTO v4.1#1
Open
rsnemmen wants to merge 4 commits intocoolastro:masterfrom
rsnemmen:edit
Open
pyPLUTO now works with datafiles created by PLUTO v4.1#1rsnemmen wants to merge 4 commits intocoolastro:masterfrom rsnemmen:edit
rsnemmen wants to merge 4 commits intocoolastro:masterfrom
rsnemmen:edit
Conversation
The grid method is not reading the grid file correctly. Need to correct for this.
had to correct line numbers and issues with columns
the previous commit works for 2D. Now this one works for 3D. Tested and working for 2D and 3D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyplut.pload.grid was not able to read correctly the output of PLUTO v4.1. It got confused when reading grid.out because of the new format of the header. I fixed the grid method and now it handles the new format of grid.out for an arbitrary number of dimensions.
Tested for 1 and 2 dimensions.