Logging cleanup#42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all
console.log/warn/errorcalls across the server codebase with the structured pino logger, fixes all ESLint errors, and silences log output during tests — eliminating noisy, non-meaningful output from test runs.Changes
Lint fixes
prefer-consterrors inalertMutes.tsandmutes/list.tsby restructuringletassignments to inlineconstLogging migration (console → pino logger)
console.error+res.status().json()to the centralizedsendErrorResponseutilitylogin.ts,logout.ts,callback.ts) now uselogger.error/warn/infoinstead ofconsole.*HealthPollingService.ts: all 8console.logcalls replaced with structuredlogger.infoauth/config.ts,auth/session.ts,auth/validateSessionSecret.ts:console.log/warn→logger.info/warndb/index.ts,db/migrate.ts:console.log→logger.infoError handling improvements
errors.ts:errorHandler,wrapHandler, andsendErrorResponsenow only log 5xx errors vialogger.error— expected 4xx errors (validation, not-found) no longer produce log outputTest output silencing
LOG_LEVEL=silenttoserver/jest.config.jsto suppress all pino output during testserrors.test.ts,config.test.ts,warnInsecureCookies.test.ts,validateSessionSecret.test.ts,HealthPollingService.test.ts) to mock the logger module instead of spying onconsole.*Testing
npm test)npm run lint)Checklist