feat: add customAnnotations, dnsConfig, and podLabels support#246
Merged
hagaibarel merged 2 commits intocoredns:masterfrom Jan 22, 2026
Merged
feat: add customAnnotations, dnsConfig, and podLabels support#246hagaibarel merged 2 commits intocoredns:masterfrom
hagaibarel merged 2 commits intocoredns:masterfrom
Conversation
Signed-off-by: Haitao Li <hli@atlassian.com>
Collaborator
|
@hligit seems like the unit test install fails, probably because of helm-unittest/helm-unittest#790. Can you please add a version pin the the lint-test workflow? It should be in https://github.com/coredns/helm/blob/master/.github/workflows/lint-test.yaml#L19-L20, and the change should be: - name: Install helm-unittest plugin
run: helm plugin install --version 1.0.2 https://github.com/helm-unittest/helm-unittest |
Signed-off-by: Haitao Li <hli@atlassian.com>
hagaibarel
approved these changes
Jan 22, 2026
Collaborator
|
Thanks for the PR! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
This PR adds several new configuration options and optimizations to the CoreDNS Helm chart:
customAnnotationssupport for ClusterRole and ClusterRoleBinding: Allows users to add custom annotations to RBAC resources for better integration with tools like GitOps, policy controllers, or organizational standards.dnsConfig: Enables custom DNS configuration for CoreDNS pods. WhendnsConfigis specified,dnsPolicyis automatically set toNoneas required by Kubernetes. This is useful for avoiding circular DNS dependencies or using external DNS resolvers.podLabels: Allows users to add custom labels specifically to pods (in addition to existingcustomLabelswhich apply to all resources). This is useful for pod-specific selectors, network policies, or monitoring configurations.automountServiceAccountToken: Allow setting it to false to follow Kubernetes best practices of only specifying fields when overriding defaults.All changes are fully backward compatible with existing configurations.
Which issues (if any) are related?
None
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.