Minor changes to main, added BDD tests#11
Open
ScottONeal wants to merge 3 commits intocoreh:masterfrom
Open
Conversation
…g. Updated package json to have repository field and testing deps.
Author
|
@coreh, If you are looking for a new maintainer for this project, let me know. I use this module and several other do as well and would like to continue development on it, instead of duplicating it onto NPM. Let me know how you would like to proceed with development efforts. Thanks! |
Author
|
ping @coreh Hey, any chance we can some attention on this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this cool package!
In effort to try continue development on this module, I added basic BDD tests. To properly handle errors in the tests, I had to add basic error handling middleware to the
lib/index.js.To run tests:
Additionally, added a spawn event which passes the child_process instance. This could be useful to hooking into and logging command output or getting the exit code.
Also, I can add a
.travis.ymlif you would like.