Make compatible with v26.1#128
Merged
Merged
Conversation
…lbackInfo::HolderV2() for Node v26
awelzel
force-pushed
the
topic/timw/node-v26-part-1
branch
from
d95329a to
0ac573b
Compare
Just to avoid some ifdefs and align with the GetZeekValWrap() change.
The message listener registration started crashing with v26.1, Opus says that's because the v8::Isolate needs to be locked first. Split the isolate setup and message listener registration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
awelzel
force-pushed
the
topic/timw/node-v26-part-1
branch
from
0ac573b to
b929f82
Compare
timwoj
approved these changes
May 22, 2026
Collaborator
timwoj
left a comment
timwoj
left a comment
There was a problem hiding this comment.
I like the helper methods. That's a lot cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tim started this and I've reworked a bit and did a CI update.
@timwoj , does this work on OSX for you? I've tested on with v26.1 and none of the distros from CI have 26.x yet.