Convert launching-containers example to use template units.#367
Convert launching-containers example to use template units.#367robszumski merged 3 commits intocoreos:masterfrom
Conversation
|
@robszumski let me know if this pull request is an adequate update to keep the docs in sync with coreos/unit-examples#5. |
|
Since this is a pretty popular guide, I want to run through it end to end this afternoon and test. Will let you know how it goes. |
|
Great. Glad to hear you’re going to run through it. I was thinking ‘hmm, this is a little dicey to update the docs without running the code’ :).= |
There was a problem hiding this comment.
I think we can get rid of "Be sure to launch both instances of the template (apache-discovery@.service), by starting apache-discovery@1 and apache-discovery@2" since it's mentioned below to start them.
|
Made a few comments. Everything worked fine for me on a 3 machine cluster. |
|
Can you find a few minutes to integrate the feedback? |
|
oops. I had the first commit sitting locally. Added a second commit for the other feedback. LMK if these edits fit the bill. |
|
Awesome, LGTM. Thanks! |
Convert launching-containers example to use template units.
2 participants
No description provided.