Don't use '--tty-' for podman shell aliases#341
Merged
Conversation
Using '--tty' conflicts with stdin redirection: https://docs.podman.io/en/latest/markdown/podman-run.1.html#tty-t
Member
Author
|
We probably still need it for coreos-installer to be able to cancel downloads. |
bgilbert
approved these changes
Dec 2, 2021
Contributor
bgilbert
left a comment
bgilbert
left a comment
There was a problem hiding this comment.
coreos-installer has a weird tradeoff: we need a TTY to cancel downloads, but need to not have one for the caller to retrieve the path to the downloaded file.
So yeah, might as well convert everything for consistency,
Member
Author
|
I'd opt for keeping things simple here in the tutorial and adding the details to the coreos-installer docs: coreos/coreos-installer#703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using '--tty' conflicts with stdin redirection:
https://docs.podman.io/en/latest/markdown/podman-run.1.html#tty-t