Skip to content

Fix handle leak#522

Open
ProjectMutilation wants to merge 1 commit into
coreos:mainfrom
ProjectMutilation:fix-handle-leak
Open

Fix handle leak#522
ProjectMutilation wants to merge 1 commit into
coreos:mainfrom
ProjectMutilation:fix-handle-leak

Conversation

@ProjectMutilation

@ProjectMutilation ProjectMutilation commented Jul 20, 2026

Copy link
Copy Markdown

Add missed Close() and removing in error path
Fixes: ca20d25 ("journal: split into read and write packages")
Found by PostgresPro

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: da560ea ("Build on Windows")

If you include a fixes line it must produce the actual commit which introduced the problem. This commit just moved the code elsewhere so listing this is is just incorrect and misleading.

Comment thread journal/journal_unix.go Outdated
Add missed Close() in error path

Fixes: ca20d25 ("journal: split into read and write packages")
Found by PostgresPro
Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants