Conversation
Because of the fact that you're using import, specifying the type as a module will allow it to be imported easily into node.js projects. Since this is not common.js (Doesn't use `require()`), this does not integrate very well with any node.js project (In my specific case next.js).
Author
|
Please please please get this pushed to npm asap, so that I can build my project without some horrendous workarounds. |
|
@danbopes while frustrating that this change is not in place almost a year down the road you should be able to fix this by using Next's dynamic import syntax to turn off SSR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the fact that you're using
import ... from ...syntax (not commonjs), specifying the type as a module will allow it to be imported into node.js projects. Since this is not common.js (Doesn't userequire()), this does not integrate very well with any node.js project (In my specific case next.js), and causes an errorSyntaxError: Cannot use import statement outside a module. Specifying the type explicitly (That this is a module) removes this error completely.