docs(smart-forms): add CDU UI pattern recipes & DOM/protocol notes#70
Open
yelyzavetaberest wants to merge 2 commits into
Open
docs(smart-forms): add CDU UI pattern recipes & DOM/protocol notes#70yelyzavetaberest wants to merge 2 commits into
yelyzavetaberest wants to merge 2 commits into
Conversation
Enrich the CDU styling skill and reference docs with live-verified UI patterns, without new files or version changes: - simulator-styles: sidebar+mainMenu indent trap, card-per-iteration wrapper, multi-token row class, table-pagination positioning, breadcrumbs via tab, sibling-combinator collapse, the .cdu-page/& gotcha, and a full image-in-cell sizing recipe. - cdu-page-protocol: mainMenu.extra depth (maxInlineDepth / submitOnBranchToggle / autoExpandActive), new §12.7 on table type:"group" pagination traps, and the multi-token row workaround. - cdu-dom-tree-reference: pagination DOM hooks, multi-token row, and the align standalone-vs-table-cell distinction. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AI ReviewAdds live-verified CDU styling recipes and cross-linked protocol/DOM notes to the Checklist
Issues found
This review was generated automatically. A human maintainer should still make the merge decision. |
The `### Interactivity (CSS-only, no backend round-trip)` heading had been split into an empty `### ` line plus an orphaned `(CSS-only, no backend round-trip)` paragraph, dropping the word "Interactivity" — an unnamed anchor that broke cross-links. Restored to a single heading line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AI ReviewRe-review after synchronize: adds live-verified CDU styling recipes and cross-linked protocol/DOM notes across the Checklist
Issues foundNo issues found. Fixed since last review ✅
This review was generated automatically. A human maintainer should still make the merge decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Enriches the CDU (Smart Form) styling skill and its two reference docs with live-verified UI patterns, so the layered docs cover recipes that were previously undocumented. No new files, no tool/frontmatter changes, no version bump — pure content additions into existing files, with cross-links between the three layers (recipe ↔ protocol ↔ DOM).
simulator-stylesskill — sidebar +mainMenuindent trap ([class*="mainMenuItem"]padding pitfall,--depth), card-per-iteration wrapper viasortable, multi-tokenrowclass, table-pagination positioning, breadcrumbs viatab, sibling-combinator collapse, the.cdu-page/&gotcha, and a full image-in-table-cell sizing recipe.cdu-page-protocol.md—mainMenu.extradepth (maxInlineDepth/submitOnBranchToggle/autoExpandActive), new §12.7 ontable type:"group"pagination traps, and the multi-tokenrowworkaround under §12.2.cdu-dom-tree-reference.md— pagination DOM hooks (§7), multi-tokenrow(§8), and thealignstandalone-vs-table-cell distinction (§6file).Type of change
Checklist
make build && make vet && make testpass locallymake discoveryneededplugins/simulator/docs/.envcommitted; TLS verification left on by defaultform, notsections#66/docs(smart-forms-logic): detect submitOnChange by buttonId, not buttonData.action #67Notes for reviewers
All three files were checked for internal duplication and cross-file consistency: the same fact (e.g. multi-token
row, pagination-outside-rows) is stated once per layer with pointers downward (protocol → DOM/styles), not repeated. Example tokens unified tomy_rowacross layers. Two known factual corrections in the neighbouring docs were deliberately left out of scope for this PR.🤖 Generated with Claude Code