Skip to content

docs(smart-forms): add CDU UI pattern recipes & DOM/protocol notes#70

Open
yelyzavetaberest wants to merge 2 commits into
corezoid:developfrom
yelyzavetaberest:docs/cdu-ui-patterns
Open

docs(smart-forms): add CDU UI pattern recipes & DOM/protocol notes#70
yelyzavetaberest wants to merge 2 commits into
corezoid:developfrom
yelyzavetaberest:docs/cdu-ui-patterns

Conversation

@yelyzavetaberest

Copy link
Copy Markdown
Contributor

What & why

Enriches the CDU (Smart Form) styling skill and its two reference docs with live-verified UI patterns, so the layered docs cover recipes that were previously undocumented. No new files, no tool/frontmatter changes, no version bump — pure content additions into existing files, with cross-links between the three layers (recipe ↔ protocol ↔ DOM).

  • simulator-styles skill — sidebar + mainMenu indent trap ([class*="mainMenuItem"] padding pitfall, --depth), card-per-iteration wrapper via sortable, multi-token row class, table-pagination positioning, breadcrumbs via tab, sibling-combinator collapse, the .cdu-page/& gotcha, and a full image-in-table-cell sizing recipe.
  • cdu-page-protocol.mdmainMenu.extra depth (maxInlineDepth / submitOnBranchToggle / autoExpandActive), new §12.7 on table type:"group" pagination traps, and the multi-token row workaround under §12.2.
  • cdu-dom-tree-reference.md — pagination DOM hooks (§7), multi-token row (§8), and the align standalone-vs-table-cell distinction (§6 file).

Type of change

  • Docs

Checklist

Notes for reviewers

All three files were checked for internal duplication and cross-file consistency: the same fact (e.g. multi-token row, pagination-outside-rows) is stated once per layer with pointers downward (protocol → DOM/styles), not repeated. Example tokens unified to my_row across layers. Two known factual corrections in the neighbouring docs were deliberately left out of scope for this PR.

🤖 Generated with Claude Code

Enrich the CDU styling skill and reference docs with live-verified UI
patterns, without new files or version changes:

- simulator-styles: sidebar+mainMenu indent trap, card-per-iteration
  wrapper, multi-token row class, table-pagination positioning,
  breadcrumbs via tab, sibling-combinator collapse, the .cdu-page/&
  gotcha, and a full image-in-cell sizing recipe.
- cdu-page-protocol: mainMenu.extra depth (maxInlineDepth /
  submitOnBranchToggle / autoExpandActive), new §12.7 on table
  type:"group" pagination traps, and the multi-token row workaround.
- cdu-dom-tree-reference: pagination DOM hooks, multi-token row, and the
  align standalone-vs-table-cell distinction.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gh-corezoid

Copy link
Copy Markdown

AI Review

Adds live-verified CDU styling recipes and cross-linked protocol/DOM notes to the simulator-styles skill and two reference docs — pure content additions, no code or manifest changes.

Checklist

Check Result
U1 · Conventional commit format ✅ pass
U2 · No leaked credentials ✅ pass
U3 · No merge commits ✅ pass
U4 · PR targets correct base branch (develop) ✅ pass
U5 · Build & test verification (Go changes) ⏭ skip — no *.go files changed
U6 · Architectural & design consequences ⏭ skip — trivial docs diff
S1 · No manual edits to public/ ⏭ skip — no public/ files changed
S2 · API path parameter names match papi-openapi.json ⏭ skip — no internal/tools/ changes
S3 · New tools have eval scenarios ⏭ skip — no new tool functions
S4 · discovery artifacts committed if source changed ⏭ skip — no internal/ changes
S5 · All six manifest files version-synced ⏭ skip — no manifest files in diff
S6 · README.md and ARCHITECTURE.md §4 updated for new tools ⏭ skip — no new tools added

Issues found

  • warningplugins/simulator/skills/simulator-styles/SKILL.md: the section heading ### Interactivity (CSS-only, no backend round-trip) was accidentally split into an empty ### heading followed by (CSS-only, no backend round-trip) as a separate paragraph. The word "Interactivity" was dropped, leaving a blank ### that renders as an unnamed anchor in the sidebar of any doc site and breaks any cross-links to that section. Fix: restore the heading to a single line — ### Interactivity (CSS-only, no backend round-trip) — or rename it intentionally if that was the goal.

This review was generated automatically. A human maintainer should still make the merge decision.

The `### Interactivity (CSS-only, no backend round-trip)` heading had been
split into an empty `### ` line plus an orphaned `(CSS-only, no backend
round-trip)` paragraph, dropping the word "Interactivity" — an unnamed
anchor that broke cross-links. Restored to a single heading line.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gh-corezoid

Copy link
Copy Markdown

AI Review

Re-review after synchronize: adds live-verified CDU styling recipes and cross-linked protocol/DOM notes across the simulator-styles skill and two reference docs — pure docs additions with the broken section heading now fixed.

Checklist

Check Result
U1 · Conventional commit format ✅ pass
U2 · No leaked credentials ✅ pass
U3 · No merge commits ✅ pass
U4 · PR targets correct base branch (develop) ✅ pass
U5 · Build & test verification (Go changes) ⏭ skip — no *.go files changed
U6 · Architectural & design consequences ⏭ skip — trivial docs diff
S1 · No manual edits to public/ ⏭ skip — no public/ files changed
S2 · API path parameter names match papi-openapi.json ⏭ skip — no internal/tools/ changes
S3 · New tools have eval scenarios ⏭ skip — no new tool functions
S4 · discovery artifacts committed if source changed ⏭ skip — no internal/ changes
S5 · All six manifest files version-synced ⏭ skip — no manifest files in diff
S6 · README.md and ARCHITECTURE.md §4 updated for new tools ⏭ skip — no new tools added

Issues found

No issues found.

Fixed since last review ✅

  • Broken ### Interactivity section heading — the empty ### line plus orphaned (CSS-only, no backend round-trip) paragraph has been merged back into the single heading ### Interactivity (CSS-only, no backend round-trip) by commit 83c8f9d0 (docs(simulator-styles): restore split "Interactivity" section heading). Cross-links to that anchor are restored.

This review was generated automatically. A human maintainer should still make the merge decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants