-
Notifications
You must be signed in to change notification settings - Fork 504
feat(dicom-image-loader): Add ability to customise path to web worker and codec wasm files #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmannau
wants to merge
21
commits into
cornerstonejs:main
Choose a base branch
from
jmannau:feature/dicom-image-loader/customize-worker-and-wasm-paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
38c0e8c
feat(dicom-image-loader): Add ability to customise path to web worker…
jmannau 076bdf1
docs(LoaderOptions): Update comments
jmannau b01cb71
fix(dicomImageLoader): fix loading libJpegTurbo wasm from custom url
jmannau 790b535
Merge remote-tracking branch 'upstream/main' into feature/dicom-image…
jmannau a7d2a89
refactor(dicom-image-loader): add additional types
jmannau 3585d61
Merge remote-tracking branch 'upstream/main' into feature/dicom-image…
jmannau 66a1848
refactor(dicom-image-loader): Refactor decodeImageFrameWorker into ty…
jmannau fc66e0c
docs(dicom-image-loader): fix comment
jmannau 5684647
fix(dicom-image-loader): Fix typescript compliation
jmannau ca74248
Merge remote-tracking branch 'upstream/main' into feature/dicom-image…
jmannau f5bed65
Merge remote-tracking branch 'origin/main' into feature/dicom-image-l…
wayfarer3130 d1c615c
fix decode image frame worker load
wayfarer3130 3cea8df
Merge remote-tracking branch 'upstream/main' into feature/dicom-image…
jmannau 0123335
refactor(dicom-image-loader):
jmannau bb93154
Merge remote-tracking branch upstream/main into feature/dicom-image-l…
jmannau 4259d14
Merge remote-tracking branch 'origin/main' into feature/dicom-image-l…
wayfarer3130 31b7908
Fix imports
wayfarer3130 a48c6bd
Use peerImport to load wasm modules
wayfarer3130 52b5212
Merge remote-tracking branch 'origin/main' into feature/dicom-image-l…
wayfarer3130 e761cea
Merge remote-tracking branch 'origin/main' into feature/dicom-image-l…
wayfarer3130 45d2758
fix: Wasm load path
wayfarer3130 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can read the TsuidConfigOptions here for the specific transferSyntaxUID, then pass it in generally below, eg
const tsuidConfigOptions = decodeConfig?.[transferSyntax]
Then other options can be passed in the future.