chore(deps): update @kitware/vtk.js to 36.4.1#2804
Conversation
Bump @kitware/vtk.js from 35.5.3 to 36.4.1 across core, tools, labelmap-interpolation, and polymorphic-segmentation. All packages build cleanly against the new major version.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdates ChangesVTK.js dependency alignment
Workspace release configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pnpm-workspace.yaml`:
- Line 21: Update the minimumReleaseAge workspace configuration from 30 minutes
back to 2880 minutes, restoring the 48-hour release-age threshold.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| linkWorkspacePackages: true | ||
| preferWorkspacePackages: true | ||
| minimumReleaseAge: 2880 | ||
| minimumReleaseAge: 30 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Restore the 48-hour release-age threshold before merging.
Reducing minimumReleaseAge to 30 minutes weakens protection against newly published compromised or typosquatted packages. Revert this temporary CI setting to 2880 before merge.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pnpm-workspace.yaml` at line 21, Update the minimumReleaseAge workspace
configuration from 30 minutes back to 2880 minutes, restoring the 48-hour
release-age threshold.
vtk.js 36.4.1 pulls in xmlbuilder2@4 -> @oozcitak/url which requires node's built-in 'url' module. Webpack 5 does not polyfill node core modules, so the Karma browser bundle failed to resolve it, breaking the vtk.js XMLReader module chain and cascading into every core test. Stub 'url' to false since XML url parsing is not exercised by the tests.
Same @oozcitak/url -> require('url') issue as the Karma fix, but in the
rspack example build used by the Playwright suite. Add url: false to both
example-build fallback blocks. Verified by building htj2kVolumeBasic.
vtk.js 36 fixes label outline border detection to include cardinal neighbors (Kitware/vtk-js@70bc9fa26), flipping one seg-edge pixel per image to the full label color. Refresh the two affected snapshots. Verified locally: main render matches these baselines at 0px on the same machine, so the update reflects CI's rendering.
1 participant
Summary
Updates
@kitware/vtk.jsfrom35.5.3to36.4.1across all consuming packages:@cornerstonejs/core@cornerstonejs/tools@cornerstonejs/labelmap-interpolation@cornerstonejs/polymorphic-segmentationThe lockfile picks up vtk.js's own transitive changes for this major version: the
@babel/preset-envpeer dependency is dropped,xmlbuilder2is bumped to 4.x, and@types/webxris re-pinned.Testing
tsc+tsc-aliaspass for core, tools, labelmap-interpolation, and polymorphic-segmentation).Summary by CodeRabbit
urlmodule is not pulled into browser builds, preventing test failures in Chrome.