fix: use subscript access in versioned_column_properties#168
Merged
winwinashwin merged 2 commits intoMay 11, 2026
Merged
Conversation
`getattr(mapper.attrs, key)` silently returns a bound method when a column name shadows a dict-API attribute on the namespace (notably `values`, `keys`, `items`). Subsequent `prop.key` access then raises `AttributeError: 'function' object has no attribute 'key'` on insert. Switch to subscript (`mapper.attrs[key]`), which bypasses normal attribute resolution and always returns the mapped property. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coverage Report for CI Build 25663163505Warning No base build found for commit Coverage: 95.136%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versioned_column_properties(and the version-table builder that consumes it) currently fails on any model with a column whose name shadows a dict-API attribute ofmapper.attrs— most notablyvalues,keys, oritems.getattr(mapper.attrs, key)resolves to the bound method on the underlyingReadOnlyPropertiesnamespace rather than theColumnProperty, so the nextprop.keyaccess inutils.pyraises:This blocks inserts on otherwise-valid versioned models. Switching to subscript (
mapper.attrs[key]) bypasses normal attribute resolution and always returns the mapped property.Changes
sqlalchemy_history/utils.py: swapgetattr(mapper.attrs, key)formapper.attrs[key]inversioned_column_properties.tests/reported_bugs/: new regression test using a model withvalues,keys, anditemscolumns. Verified to reproduce the originalAttributeErroragainst unfixedutils.pyand to pass after the fix.CHANGES.rst: add an Unreleased entry describing the fix.Test plan
utils.pymainwith the documentedAttributeErrorruff checkandruff format --checkclean on changed filestests/relationships/between fixed and unfixed builds (pre-existing failures are unrelated)🤖 Generated with Claude Code