Async sqlalchemy support#169
Merged
Merged
Conversation
Contributor
winwinashwin
commented
May 11, 2026
winwinashwin
commented
- docs: Fix typos in docs
- chore: Remove flexmock from test deps
- refactor: Remove support for sqlalchemy-i18n
- chore: Add anyio to core deps and async db drivers to test deps
- feat(Async SQLAlchemy support #165): Support version traversal with async sqlalchemy
winwinashwin
force-pushed
the
ashwin/contrib-async
branch
6 times, most recently
from
c962844 to
58aa375
Compare
Coverage Report for CI Build 25669055356Warning No base build found for commit Coverage: 96.104%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
winwinashwin
force-pushed
the
ashwin/contrib-async
branch
from
58aa375 to
1a4fc07
Compare
AbdealiLoKo
reviewed
May 11, 2026
| dependencies = ["SQLAlchemy>=2", "SQLAlchemy-Utils>=0.30.12", "anyio>3"] | ||
|
|
||
| [project.optional-dependencies] | ||
| asyncio = ["SQLAlchemy[asyncio]>=2"] |
Contributor
There was a problem hiding this comment.
I vaguely recall some bug where pip resolution does not consider extras.
So, if you pip install sqlalchemy-history and then pip install sqlalchemy-history[asyncio] does pip just say sqlalchemy is already installed ? or does it install asyncio extra from sqlalchemy ?
Contributor
Author
There was a problem hiding this comment.
Tested. pip installs asyncio extra
AbdealiLoKo
reviewed
May 11, 2026
winwinashwin
force-pushed
the
ashwin/contrib-async
branch
from
addd517 to
38c2e57
Compare
We don't use it, remove it.
winwinashwin
force-pushed
the
ashwin/contrib-async
branch
from
38c2e57 to
b133f11
Compare
AbdealiLoKo
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.