refactor: add PEP 484 type annotations across the codebase (#164)#170
Open
Chimankarparag wants to merge 1 commit into
Open
refactor: add PEP 484 type annotations across the codebase (#164)#170Chimankarparag wants to merge 1 commit into
Chimankarparag wants to merge 1 commit into
Conversation
) Add comprehensive type hints to all core modules using Python 3.9+ compatible syntax (no 'from __future__ import annotations'). - Annotate factory, operation, schema, version, utils, fetcher, reverter, transaction, expression_reflector modules - Annotate table_builder, model_builder, relationship_builder, builder - Annotate manager, unit_of_work, and __init__ public API - Annotate all plugins (activity, base, null_delete, property_mod_tracker, transaction_changes, transaction_meta) - Use TYPE_CHECKING guards to prevent circular imports - Fix pre-existing ruff warnings (FBT001, PERF401, A003)
Author
|
The Test cases failed due an incompatible annotations in utils.py |
Coverage Report for CI Build 25801782794Warning No base build found for commit Coverage: 95.68%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive type hints to all core modules using Python 3.9+ compatible syntax (no 'from future import annotations').