fix CI for Windows#233
Merged
Causeless merged 2 commits intocortex-command-community:developmentfrom Nov 14, 2025
Merged
Conversation
Contributor
Author
what ok give me a minute ok |
Contributor
Author
|
Oh, understandable.
HECK! |
Contributor
Author
guhhhhhhhhhhhhhhhhhhhhhhhh this needs more effort i guess |
Contributor
Author
|
ALL GREEN MOTHERFUCKER ✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅ edit: sorry, got carried away all green though ✅✅✅✅ |
HeliumAnt
approved these changes
Nov 13, 2025
Contributor
HeliumAnt
left a comment
There was a problem hiding this comment.
Funky, usually it's the linux that finds these things. Good catch!
Contributor
|
✅ |
230d38b
into
cortex-command-community:development
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File
Entity.husesstd::mutexbut never actually does#include <mutex>.As far as I can tell, it just happened by chance that:
# include <bits/std_mutex.h>is written in file/usr/include/c++/15.2.1/bits/atomic_wait.hfrom the GNU C++ library implementation/usr/include/c++/15.2.1/bits/atomic_base.h/usr/include/c++/15.2.1/bits/shared_ptr_atomic.h/usr/include/c++/15.2.1/memory<memory>bySource/System/Reader.hSource/System/Serializable.hSource/System/Entity.h...But of course, I assume GNU C++ library is not used by Microsoft's compiler, and files that they do have likely don't end up including mutex.
So, just, include the mutex where it's used.