fix: use correct podAnnotations reference in purger deployment#613
Open
archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
Open
fix: use correct podAnnotations reference in purger deployment#613archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
archy-rock3t-cloud wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
archy-rock3t-cloud
force-pushed
the
fix/purger-pod-annotations
branch
from
648840d to
0cff471
Compare
kd7lxl
reviewed
Apr 9, 2026
CHANGELOG.md
Outdated
|
|
||
| ## master / unreleased | ||
|
|
||
| * [BUGFIX] Purger: use correct podAnnotations reference instead of query_frontend's |
Collaborator
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Purger: use correct podAnnotations reference instead of query_frontend's | |
| * [BUGFIX] Purger: use correct podAnnotations reference instead of query_frontend's #613 |
Collaborator
There was a problem hiding this comment.
I tried to add the PR number to the changelog myself, but with Github UI it doesn't pass the DCO, and I don't have permission to push to your fork directly. You'll have to do it yourself.
Otherwise, this PR looks great. Thanks!
nschad
approved these changes
Apr 10, 2026
Collaborator
|
you still have to sign the DCO @archy-rock3t-cloud. Great PR though, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The purger deployment template references
.Values.query_frontend.podAnnotationsinstead of.Values.purger.podAnnotations, so any pod annotations configured for the purger component are never applied.Which issue(s) this PR fixes:
N/A — found by code review.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]