fix: add wildcard route with redirect to root#72
Open
corvid-agent wants to merge 1 commit intomainfrom
Open
Conversation
Navigating to an unknown URL (e.g., /nonexistent) showed an empty outlet with no user feedback. Add a catch-all ** route inside ShellComponent's children that redirects to the welcome page. Adds 2 route-config tests verifying the wildcard exists and is last. Fixes #71 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Review: LGTM ✓ Clean, minimal change. The wildcard route with The two route-level tests verify both the redirect target and the positioning — straightforward and sufficient. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**route insideShellComponentchildren that redirects unknown URLs to the welcome pageFixes #71
Test plan
ng test --no-watchpasses (385 tests, 18 files)npx tsc --noEmitpasses/nonexistent— should redirect to welcome page🤖 Generated with Claude Code