Skip to content

feat: improve responsive layout #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendyyuchensun merged 3 commits into from
May 19, 2026
+18 −10
Merged

feat: improve responsive layout #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b6123c
feat: stack right col below left col at 1024 breakpoint
wendyyuchensun May 18, 2026
17be4e2
feat: minimun page width 768px
wendyyuchensun May 18, 2026
d1ae43b
chore: minor adjust in style to fit rwd
wendyyuchensun May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const Header = ({ onImportClick, onExportClick, title, onTitleChange }) => {
const [showTipModal, setShowTipModal] = useState(false);

return (
<header className="px-6 fixed h-[72px] flex items-center gap-2 bg-white inset-x-0 z-10 shadow-shadow2">
<header className="px-6 sticky top-0 min-w-[768px] h-[72px] flex items-center gap-2 bg-white z-10 shadow-shadow2">
<div className="flex items-center gap-3 grow">
<h1 className="sr-only">Access8Math</h1>
<A8mLogo aria-hidden="true" />
Expand All @@ -31,18 +31,22 @@ const Header = ({ onImportClick, onExportClick, title, onTitleChange }) => {
<div className="flex items-center gap-3">
<Button
variant="tertiary"
className="min-w-[88px] flex items-center gap-1"
className="min-w-[64px] lg:min-w-[88px] flex items-center gap-1"
onClick={() => setShowTipModal(true)}
>
<IconBulb size={16} aria-hidden="true" />
<span>{t('instructions')}</span>
</Button>
<Menu />
<LanguageMenu />
<Button variant="secondary" className="min-w-[88px]" onClick={onImportClick}>
<Button
variant="secondary"
className="min-w-[64px] lg:min-w-[88px]"
onClick={onImportClick}
>
{t('import')}
</Button>
<Button variant="primary" className="min-w-[88px]" onClick={onExportClick}>
<Button variant="primary" className="min-w-[64px] lg:min-w-[88px]" onClick={onExportClick}>
{t('export')}
</Button>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/components/header/language-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ const LanguageMenu = () => {
return (
<DropdownMenu
triggerButton={
<Button variant="tertiary" className="min-w-[88px]" aria-label={t('changeLocale')}>
<Button
variant="tertiary"
className="min-w-[64px] lg:min-w-[88px]"
aria-label={t('changeLocale')}
>
<IconLanguage size={16} className="flex-none mr-1" aria-hidden="true" />
<span>{t(`locale.${i18n.language}`)}</span>
</Button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const NativeMenu = () => {
return (
<DropdownMenu
triggerButton={
<Button variant="tertiary" className="min-w-[88px]" aria-label={t('more')}>
<Button variant="tertiary" className="min-w-[64px] lg:min-w-[88px]" aria-label={t('more')}>
<IconDots size={16} className="flex-none mr-1" aria-hidden="true" />
<span>{t('more')}</span>
</Button>
Expand Down
8 changes: 4 additions & 4 deletions src/pages/home/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,9 @@ export default function Home() {
title={displayConfig.title}
onTitleChange={(title) => setDisplayConfig({ title })}
/>
<main className="pt-[72px] flex flex-col md:flex-row overflow-x-hidden overflow-y-auto">
<main className="min-w-[768px] flex flex-col lg:flex-row">
{/* Left side input panel */}
<div className="md:w-3/5 bg-blue-50 p-6">
<div className="lg:w-3/5 bg-blue-50 p-6">
<div className="flex items-center justify-between mb-4">
<h2>{t('editContent')}</h2>
<div className="flex items-center gap-2">
Expand All @@ -336,7 +336,7 @@ export default function Home() {
items={latexDelimiterOptions}
value={displayConfig.latexDelimiter}
onChange={(option) => setDisplayConfig({ latexDelimiter: option })}
buttonClassName="w-[88px] h-7"
buttonClassName="w-[64px] h-7"
/>
</div>
<Button variant="secondary" onClick={insertMark}>
Expand Down Expand Up @@ -378,7 +378,7 @@ export default function Home() {
</div>

{/* Right side output panel */}
<div className="md:w-2/5 flex flex-col md:h-full h-[600px] p-6">
<div className="lg:w-2/5 flex flex-col lg:h-full h-[600px] p-6">
<div className="flex justify-between items-center mb-4">
<h2>{t('preview')}</h2>
<div>
Expand Down
Loading