Skip to content

Prevent buffer overflow in Value::getStringBytes #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snej merged 1 commit into from
Jul 19, 2023
Merged

Prevent buffer overflow in Value::getStringBytes #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Fleece/Core/Value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ namespace fleece { namespace impl {
// This means the actual length follows as a varint:
uint32_t length;
size_t lengthBytes = GetUVarInt32(s, &length);
if (_usuallyFalse(lengthBytes == 0))
// Invalid data, but I'm not allowed to throw an exception.
return nullslice;
return slice(&s[lengthBytes], length);
}
return s;
Expand Down