Admin API disabled by default (opt-in via --admin-api)#1968
Draft
Admin API disabled by default (opt-in via --admin-api)#1968
Conversation
Copilot
AI
changed the title
[WIP] Fix admin API to not be enabled by default
Admin API disabled by default (opt-in via --admin-api)
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Admin API was on by default — any process on the machine could read/modify server state without explicit opt-in. This flips it to opt-in: pass
--admin-apito enable it.Original Prompt
Issue: Admin API default off
Do not enable the admin api by default
Manual acceptance tests
counterfact api.yaml ./api(no flags) returns 404 forGET /_counterfact/api/healthcounterfact api.yaml ./api --admin-apireturns 200 forGET /_counterfact/api/health--admin-apiis passed without--admin-api-tokencounterfact --helpshows--admin-api(enable) instead of--no-admin-api(disable)startAdminApi: falseexplicitly are unaffectedTasks
.option("--no-admin-api", ...)→.option("--admin-api", ...)insrc/cli/run.ts— Commander now defaultsadminApitoundefined(falsy) instead oftruedocs/reference.mdCLI reference table:--admin-apiwith defaultfalseminorchangeset (default behavior change)