-
Notifications
You must be signed in to change notification settings - Fork 152
Remove duplicate NATIVE_PRICE_ESTIMATORS from docker-compose.fork.yml #4064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a duplicate NATIVE_PRICE_ESTIMATORS environment variable in docker-compose.fork.yml, which improves configuration clarity. However, I've noticed that the remaining NATIVE_PRICE_ESTIMATORS variable appears to be incorrectly formatted and would likely cause a parsing error at runtime. I've left a comment with a suggestion to fix this related issue. Addressing this would make the configuration fully correct.
|
@MarcusWentz, please accept the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
|
@MarcusWentz since the CI still fails, I assume the message should only contain the following text, without mentioning anyone: |
|
I have read the CLA Document and I hereby sign the CLA |
Description
Autopilot flag
NATIVE_PRICE_ESTIMATORSset with 2 different values in docker-compose.fork.yml.Changes
Related Issues
#4063