Skip to content

[fix][evaluation] fix npe&retry issue#528

Merged
xueyizheng merged 4 commits into
mainfrom
fix/ol_expt_fix
May 26, 2026
Merged

[fix][evaluation] fix npe&retry issue#528
xueyizheng merged 4 commits into
mainfrom
fix/ol_expt_fix

Conversation

@xueyizheng
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@xueyizheng xueyizheng requested a review from lizwang11 May 20, 2026 12:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...d/modules/evaluation/application/experiment_app.go 75.00% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   77.33%   77.32%   -0.01%     
==========================================
  Files         657      657              
  Lines       73826    73835       +9     
==========================================
+ Hits        57091    57096       +5     
- Misses      13346    13348       +2     
- Partials     3389     3391       +2     
Flag Coverage Δ
unittests 77.32% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...modules/evaluation/application/eval_openapi_app.go 92.63% <100.00%> (+0.02%) ⬆️
...d/modules/evaluation/application/experiment_app.go 84.51% <75.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd86741...68f479f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xueyizheng xueyizheng merged commit 8420c27 into main May 26, 2026
16 checks passed
@xueyizheng xueyizheng deleted the fix/ol_expt_fix branch May 26, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants