Skip to content

[fix][evaluation] expose async target record while processing#533

Merged
caijialin0626 merged 2 commits into
mainfrom
codex/coze-video-async-target-logid
May 26, 2026
Merged

[fix][evaluation] expose async target record while processing#533
caijialin0626 merged 2 commits into
mainfrom
codex/coze-video-async-target-logid

Conversation

@caijialin0626
Copy link
Copy Markdown
Collaborator

What

  • Backfill processing turn results with TargetResultID from turn run logs.
  • Allow experiment result payloads to include target_record/logid/trace_id while async target items are still processing.

Verification

  • go test ./modules/evaluation/domain/service -run TestExptResultServiceImpl_MGetExperimentResult_FillsProcessingTargetRecordFromRunLog
  • go test ./modules/evaluation/domain/service -run TestExptResultServiceImpl_MGetExperimentResult
  • E2E PPE experiment 7590096217044173570 shows two processing rows with distinct target_logid values.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ules/evaluation/domain/service/expt_result_impl.go 83.92% 4 Missing and 5 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   77.33%   77.39%   +0.06%     
==========================================
  Files         657      657              
  Lines       73826    73871      +45     
==========================================
+ Hits        57091    57171      +80     
+ Misses      13346    13306      -40     
- Partials     3389     3394       +5     
Flag Coverage Δ
unittests 77.39% <83.92%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/evaluation/domain/service/expt_result_impl.go 75.17% <83.92%> (+2.52%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd86741...d6f9166. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xueyizheng xueyizheng self-requested a review May 26, 2026 07:28
@caijialin0626 caijialin0626 merged commit 223e42c into main May 26, 2026
16 checks passed
@caijialin0626 caijialin0626 deleted the codex/coze-video-async-target-logid branch May 26, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants