ci: add workflow_dispatch to Deploy for cross-repo triggers#263
ci: add workflow_dispatch to Deploy for cross-repo triggers#263leostar0412 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe deploy workflow now supports manual ChangesManual Deployment Support
Possibly Related PRs
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy.yml:
- Line 38: SCRIPT_URL is constructed using github.sha for workflow_dispatch
while BRANCH uses github.event.inputs.ref, which can cause deploy script/branch
mismatch; change SCRIPT_URL to use the same computed ref/variable as BRANCH (or
introduce a single REF variable used by both) so both the branch to deploy and
the URL to fetch the deploy script resolve from the same source (use
github.event.inputs.ref when present for workflow_dispatch, otherwise fall back
to github.sha) and update the SCRIPT_URL expression to reference that shared REF
variable instead of github.sha.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5bf331da-0c88-4e47-8a6c-2ebb08a9a0e0
📒 Files selected for processing (1)
.github/workflows/deploy.yml
…branch for manual triggers
|
@coderabbitai full review |
✅ Action performedFull review finished. |
jonathanMLDev
left a comment
There was a problem hiding this comment.
Please update docs/deployment.md too
Summary
workflow_dispatchand arefinput (develop|main).workflow_runtrigger after CI on push unchanged.BRANCH, environment (staging/production), andSCRIPT_URLwork for both triggers.Apps touched
Allows a trusted external workflow (e.g. a private overlay repo) to start Deploy after its own CI passes, without adding overlay-specific names or secrets to this public repository. Server deploy still uses environment
DEPLOY_SCRIPT_URLwhen configured.Test plan
python -m pytest(or scoped:python -m pytest <app>/tests)uv run pyright(if typed code changed)lint-imports(if imports or cross-app coupling changed)Related cppalliance/wg21-reflector-collector#2
Summary by CodeRabbit
New Features
Chores