Migrate remaining 6 tools(core:4, alliance: 2)

[jonathanMLDev]

Summary

Branch name: feat/server-context-migrate-remaining-tools

Core tools migrated (4)

• keyword-search-tool.ts — ctx.getClient()
• query-documents-tool.ts — ctx.requireSuggested() + ctx.getClient()
• generate-urls-tool.ts — ctx.generateUrlForNamespace()
• namespace-router-tool.ts — ctx.getNamespacesWithCache()

Alliance tools migrated (2)

• suggest-query-params-tool.ts — ctx.getNamespacesWithCache() + ctx.markSuggested()
• guided-query-tool.ts — all three context methods

Setup wiring

• core/setup.ts — passes ctx to all 7 core registrars
• alliance/setup.ts — retrieves context via getDefaultServerContext() and passes it to Alliance registrars

New context tests (6)

• keyword-search-tool.context.test.ts
• query-documents-tool.context.test.ts
• generate-urls-tool.context.test.ts
• namespace-router-tool.context.test.ts
• suggest-query-params-tool.context.test.ts
• guided-query-tool.context.test.ts

Verification

• 187 tests passed (37 files), including all 9 .context.test.ts files
• Build succeeded
• Legacy *.test.ts files unchanged

Related Issue

• Close Migrate remaining 6 tools to ServerContext #131

Summary by CodeRabbit

Release Notes

• New Features

  • Tool registration functions now support optional server context for enhanced state management, namespace caching, and client access.
  • Improved context-driven operations across query handling, URL generation, and namespace routing.

• Tests

  • Added comprehensive test suites validating context-aware tool handler behavior across core and alliance operations.

[coderabbitai]

Warning

Review limit reached

@jonathanMLDev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 32 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7c334008-74fa-45f7-9394-8ae85c8841f0

📥 Commits

Reviewing files that changed from the base of the PR and between ccff5c9 and 6c11ebc.

📒 Files selected for processing (14)

• src/alliance/setup.ts
• src/alliance/tools/guided-query-tool.context.test.ts
• src/alliance/tools/guided-query-tool.ts
• src/alliance/tools/suggest-query-params-tool.context.test.ts
• src/alliance/tools/suggest-query-params-tool.ts
• src/core/server/tools/generate-urls-tool.context.test.ts
• src/core/server/tools/generate-urls-tool.ts
• src/core/server/tools/keyword-search-tool.context.test.ts
• src/core/server/tools/keyword-search-tool.ts
• src/core/server/tools/namespace-router-tool.context.test.ts
• src/core/server/tools/namespace-router-tool.ts
• src/core/server/tools/query-documents-tool.context.test.ts
• src/core/server/tools/query-documents-tool.ts
• src/core/setup.ts

📝 Walkthrough

Walkthrough

Six MCP tools (keyword_search, query_documents, generate_urls, namespace_router, suggest_query_params, guided_query) are updated to accept an optional ServerContext parameter. When provided, handlers route through context methods; otherwise they use module-level facades. Setup functions create and pass the context to all tool registrations. New .context.test.ts files validate the context path for each tool.

Changes

ServerContext tool migration

Layer / File(s)	Summary
Core tools: keyword_search, query_documents, generate_urls, namespace_router migrations src/core/server/tools/keyword-search-tool.ts, src/core/server/tools/keyword-search-tool.context.test.ts, src/core/server/tools/query-documents-tool.ts, src/core/server/tools/query-documents-tool.context.test.ts, src/core/server/tools/generate-urls-tool.ts, src/core/server/tools/generate-urls-tool.context.test.ts, src/core/server/tools/namespace-router-tool.ts, src/core/server/tools/namespace-router-tool.context.test.ts	All four core server tools now accept optional ctx?: ServerContext. Each tool conditionally uses ctx.getClient(), ctx.requireSuggested(), ctx.getNamespacesWithCache(), or ctx.generateUrlForNamespace() when context is provided; otherwise falls back to module-level facades (getPineconeClient(), requireSuggested(), getNamespacesWithCache(), generateUrlForNamespace()). New .context.test.ts files test handler execution via context injection with mocked clients and state.
Alliance tools: suggest_query_params, guided_query migrations src/alliance/tools/suggest-query-params-tool.ts, src/alliance/tools/suggest-query-params-tool.context.test.ts, src/alliance/tools/guided-query-tool.ts, src/alliance/tools/guided-query-tool.context.test.ts	Both Alliance tools now accept optional ctx?: ServerContext. When provided, tools use ctx.getNamespacesWithCache(), ctx.markSuggested(), and ctx.getClient(); otherwise fall back to module-level implementations. New .context.test.ts files exercise the context path with mocked namespace metadata, client queries, and suggestion tracking verification.
Setup integration: core and alliance server context wiring src/core/setup.ts, src/alliance/setup.ts	Core setup passes context to all four core tool registrations (registerNamespaceRouterTool, registerKeywordSearchTool, registerQueryDocumentsTool, registerGenerateUrlsTool). Alliance setup creates a default ServerContext via getDefaultServerContext() and passes it to both Alliance tool registrations (registerSuggestQueryParamsTool, registerGuidedQueryTool).

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• cppalliance/pinecone-read-only-mcp-typescript#130: Foundational ServerContext work that this PR extends to the remaining tools.
• cppalliance/pinecone-read-only-mcp-typescript#31: Introduced the keyword_search tool whose context routing is now updated in this PR.
• cppalliance/pinecone-read-only-mcp-typescript#109: Initial setup flow architecture that this PR's setup wiring complements.

Suggested labels

enhancement

Suggested reviewers

• wpak-ai
• AuraMindNest

Poem

🐰 The context now flows through each tool's eager paws,
No more module globals breaking server laws,
Test paths shine bright where contexts convene,
Six tools dance free in the setup routine.
Alliance and core, now unified and spry! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references 6 tools being migrated but the PR summary indicates 9 tools were actually migrated (4 core + 2 alliance + 3 additional)	Update the title to accurately reflect that 9 tools were migrated, or clarify which 6 tools are the primary focus if that was intentional.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	All acceptance criteria from issue #131 are met: all 6 tools migrated with optional ctx parameter, setupCoreServer/setupAllianceServer wired to pass ctx, and .context.test.ts files added for all newly migrated tools.
Out of Scope Changes check	✅ Passed	All code changes are directly aligned with issue #131 objectives. No unrelated changes or scope creep detected in the migrated tools or test files.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ccff5c9). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage        ?   84.49%           
=======================================
  Files           ?       39           
  Lines           ?     1419           
  Branches        ?      483           
=======================================
  Hits            ?     1199           
  Misses          ?      218           
  Partials        ?        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jonathanMLDev]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[jonathanMLDev]

@coderabbitai full review again

[coderabbitai]

@jonathanMLDev Sure, I'll kick off another full review of the PR right away!

✅ Action performed

Full review finished.

[jonathanMLDev]

@coderabbitai full review again

[coderabbitai]

@jonathanMLDev Sure, I'll kick off another full review of PR #132 right away!

✅ Action performed

Full review finished.