fixed TSAN errors in Timer::stop() with --showtime=file and multiple threads

Author: firewave

lib/timer.cpp

@@ -23,6 +23,8 @@
 #include <utility>
 #include <vector>
 
+// TODO: print through a synchronized logger
+
 namespace {
     using dataElementType = std::pair<std::string, struct TimerResultsData>;
     bool more_second_sec(const dataElementType& lhs, const dataElementType& rhs)
@@ -122,6 +124,7 @@ void Timer::stop()
 
         if (mShowTimeMode == SHOWTIME_MODES::SHOWTIME_FILE) {
             const double sec = (double)diff / CLOCKS_PER_SEC;
+            std::lock_guard<std::mutex> l(mCoutLock);
             std::cout << mStr << ": " << sec << "s" << std::endl;
         } else if (mShowTimeMode == SHOWTIME_MODES::SHOWTIME_FILE_TOTAL) {
             const double sec = (double)diff / CLOCKS_PER_SEC;
@@ -134,3 +137,5 @@ void Timer::stop()
 
     mStopped = true;
 }
+
+std::mutex Timer::mCoutLock;

lib/timer.h

@@ -88,6 +88,7 @@ class CPPCHECKLIB Timer {
     std::clock_t mStart;
     const SHOWTIME_MODES mShowTimeMode;
     bool mStopped;
+    static std::mutex mCoutLock;
 };
 //---------------------------------------------------------------------------
 #endif // timerH