CheckUnusedVar: My fix for #4955 was a quick fix causing false negatives. Fix some FN and add TODO to handle other FN better.

danmar · danmar · commit f6161c6f89b3 · 2016-01-31T09:11:52.000+01:00
diff --git a/lib/checkunusedvar.cpp b/lib/checkunusedvar.cpp
@@ -772,8 +772,10 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const
             break;
         }
         if (tok->isName() && tok->str().back() == '>') {
+            // TODO: This is a quick fix to handle when constants are used
+            // as template parameters. Try to handle this better, perhaps
+            // only remove constants.
             variables.clear();
-            break;
         }
 
         // bailout when for_each is used

Original file line number	Diff line number	Diff line change
`@@ -772,8 +772,10 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const`
`772`	`772`	`break;`
`773`	`773`	`}`
`774`	`774`	`if (tok->isName() && tok->str().back() == '>') {`
	`775`	`+ // TODO: This is a quick fix to handle when constants are used`
	`776`	`+ // as template parameters. Try to handle this better, perhaps`
	`777`	`+ // only remove constants.`
`775`	`778`	`variables.clear();`
`776`		`- break;`
`777`	`779`	`}`
`778`	`780`
`779`	`781`	`// bailout when for_each is used`