Resolve attributes as cross-references#115
Merged
Merged
Conversation
mwoehlke
force-pushed
the
attributes-are-references
branch
2 times, most recently
from
856ddd8 to
dae560d
Compare
mwoehlke-kitware
approved these changes
Jun 8, 2026
Rewrite the `attribute` role to be a domain specific cross reference that is resolved against the actual collected attributes set. While our previous practice of creating attribute links using standard references was functional, it made it somewhat awkward to elide the object context for overloaded attributes, and resulted in inconsistency between linked and unlinked attribute references in both markup and visual rendering. Generating the references ourself gives improved consistency of visual presentation, as well as simplified and more standard mechanisms for specifying whether a reference to an overloaded attribute should be qualified. Additionally, resolving references against our internal attribute model (as compared to the previous behavior which effectively used only section targets) means that attributes can be qualified, whether or not they are overloaded, which makes resolution more robust.
mwoehlke
force-pushed
the
attributes-are-references
branch
from
dae560d to
1122f58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the
attributerole to be a domain specific cross reference that is resolved against the actual collected attributes set. While our previous practice of creating attribute links using standard references was functional, it made it somewhat awkward to elide the object context for overloaded attributes, and resulted in inconsistency between linked and unlinked attribute references in both markup and visual rendering.Generating the references ourself for improved consistency of visual presentation, as well as simplified and more standard mechanisms for specifying whether a reference to an overloaded attribute should be qualified. Additionally, resolving references against our internal attribute model (as compared to the previous behavior which effectively used only section targets) means that attributes can be qualified, whether or not they are overloaded, which makes resolution more robust.