Skip to content

Fix CDN path invalidation for replaced assets with the same filename #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angrybrad merged 3 commits into from
Jun 10, 2026
Merged

Fix CDN path invalidation for replaced assets with the same filename #196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df3eb6
Fix CDN path invalidation for replaced assets with the same filename
white-mark-w Mar 19, 2026
3fd1fbb
Update comments and fix optional chaining in Plugin.php
angrybrad Jun 10, 2026
80d57aa
Fix formatting of folderPath assignment
angrybrad Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,15 @@ function(ReplaceAssetEvent $event) {
$oldFilename = $asset->getFilename();
$newFilename = $event->filename;

// when replacing asset with another one with the same filename, invalidate the cdn path for the original file too
// see https://github.com/craftcms/aws-s3/issues/184 for details
// when replacing an asset with another one with the same filename, invalidate the CDN path for the original file too
// see https://github.com/craftcms/aws-s3/issues/184 and https://github.com/craftcms/aws-s3/issues/195 for details
if ($oldFilename === $newFilename) {
$fs->invalidateCdnPath($asset->getPath());
$folderPath = trim($asset->getFolder()->path, '/');
$oldPath = $folderPath !== ''
? $folderPath . '/' . $oldFilename
: $oldFilename;

$fs->invalidateCdnPath($oldPath);
}
}
);
Expand Down
Loading