John McNamara/Claire Arthur **harte implementation#47
Open
johnnymac647 wants to merge 9 commits intocraigsapp:masterfrom
Open
John McNamara/Claire Arthur **harte implementation#47johnnymac647 wants to merge 9 commits intocraigsapp:masterfrom
johnnymac647 wants to merge 9 commits intocraigsapp:masterfrom
Conversation
Added preliminary code to parse the information in the <degree> musicxml tag and include that information in the output harmony string.
Degree information is now displayed in a more sensible way. The **hart representation of the harmony is also shown, although it does not yet account for the information in the <degree> tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in this pull request modifies the "musicxml2hum" function so that information included in musicxml tags is formatted in accordance with our proposed "**harte" standard (outlined in Harte et al 2005, attached). And example xml and output .krn file are also attached.
Harte et al. 2005 - SYMBOLIC REPRESENTATION OF MUSICAL CHORDS A PROPO.pdf
)
test_files.zip