[myank] Keep *mclef, *oclef, *mmet and *omet interpretations#95
Open
WolfgangDrescher wants to merge 2 commits intocraigsapp:masterfrom
Open
[myank] Keep *mclef, *oclef, *mmet and *omet interpretations#95WolfgangDrescher wants to merge 2 commits intocraigsapp:masterfrom
*mclef, *oclef, *mmet and *omet interpretations#95WolfgangDrescher wants to merge 2 commits intocraigsapp:masterfrom
Conversation
This was referenced Feb 12, 2024
WolfgangDrescher
added a commit
to WolfgangDrescher/lassus-bicinium-project
that referenced
this pull request
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
This is not the best solution as a lot of code is repeated, but it works… Having a look at
modoriwe should probably also add*okand*mk,*oI",*mI",*oI',*mI'.Could you please check the changes in
Tool_myank::getMetStatesand especially the regex inTool_myank::getLocalMetInfo. I'm not sure I caught this edge case.