Skip to content

[pre-commit.ci] pre-commit autoupdate#55

Open
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config
Open

[pre-commit.ci] pre-commit autoupdate#55
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Feb 19, 2024

Copy link
Copy Markdown

@pre-commit-ci pre-commit-ci Bot requested a review from viega as a code owner February 19, 2024 17:01
@miki725

miki725 commented Feb 19, 2024

Copy link
Copy Markdown
Collaborator

most of these are fixed in dev branch. once its merge to main this will go away

@ee7

ee7 commented Feb 29, 2024

Copy link
Copy Markdown

Are we happy to merge this? I want to be able to PR against the main branch without my PR branch being auto-updated for unrelated changes.

And If we end up rebasing dev on top of main, merging this PR will also reduce the whitespace noise in commits from the dev branch.

@miki725

miki725 commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

Let's not. Dev already had these fixes and the bump does not impact any of the hooks we use. Rebasing dev branch might break older chalk releases as the older commits might be cleaned up by GitHub as con4m pins to specific commits.

@ee7 ee7 mentioned this pull request Mar 1, 2024
@ee7

ee7 commented Mar 1, 2024

Copy link
Copy Markdown

Rebasing dev branch might break older chalk releases

Oh, of course. Sure - let's make sure those dev commit refs end up main, then.

However, could we still merge this PR, and then merge dev and main later with a merge commit? I want to merge #64 to main, and right now, that PR has unrelated whitespace fixes.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8123831 to 0fcd658 Compare April 8, 2024 17:02
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from af2923d to 98fb573 Compare October 7, 2024 17:14
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v6.0.0](pre-commit/pre-commit-hooks@v4.4.0...v6.0.0)
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8d90e22 to 1d494df Compare August 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants