Remove node-sass, bump node to 22.10, bootstrap 5.3 and sass to 1.77.6#864
Remove node-sass, bump node to 22.10, bootstrap 5.3 and sass to 1.77.6#864
22.10, bootstrap 5.3 and sass to 1.77.6#864Conversation
node-sass, bump node to 22.10, bootstrap 5.3 and sass to 1.77.622.10, bootstrap 5.3 and sass to 1.77.6
|
Excellent to have all this bundled together into a single commit, derived from others, so we can easily revert, when needed. Thanks a stack! What do you think about integrating this patch, despite the project officially being on a maintenance hiatus? At least, it would mitigate some flags on downstream security scanners, remember that admin ui is also bundled into OCI images. |
|
@amotl do we maybe need to update the |
The current stalling in "Post Setup Node.js" is originating from saving its
Don't know why that took so long. However, if it's not about "total size", it might easily also be about "number of files", that increases cache write duration. Otherwise, the lengthy runtime can also originate from datacenter/hardware congestion hiccups. The good thing is that on all other PRs, the cache will only be read, and not written.
Yeah, please do like GH-863 is doing it. Thanks! |
|
yes please, maybe I missed something on my local setup, more eyes = appreciated! |
As the title suggests, this patch removes the deprecated
node-sasspackage, updatesnode&npm, updatesbootstrap,sassandsass-loader. As explained in #852 (comment)sassneeded to be locked to a specific version in order to avoid deprecation warnings from bootstraps scss assets.Summary of the changes / Why this is an improvement
Suggested by #852 (comment) this is a combination of both GH-852 and GH-863.