Dependencies: Permit installation of click 8.3

[amotl]

About

Update to newer click package.

References

• Update dependency click to <8.4 - autoclosed #628

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Relaxed the click dependency upper bound and noted it in CHANGES.md; changed the --anonymize CLI option to behave as a flag that supplies a default decoder path; removed mix_stderr=False from several click.testing.CliRunner(...) usages and tightened some test exit-code assertions to include CLI output.

Changes

Cohort / File(s)	Summary
Dependency & Changelog CHANGES.md, pyproject.toml	Updated changelog and relaxed Click constraint from click<8.2 to click<8.4, permitting Click 8.3.
CLI option cratedb_toolkit/cfr/cli.py	Changed @click.option("--anonymize", ...) from a string option requiring a value to a flag-like option (is_flag=True, flag_value="decoder_dictionary.json"), so using --anonymize without an argument supplies the default decoder path.
Tests — CliRunner & assertions tests/cfr/test_systable.py, tests/cfr/test_jobstats.py, tests/settings/test_cli.py	Removed mix_stderr=False from click.testing.CliRunner setups (now conditionally provided via a fixture in one test file); several assert result.exit_code == 0 lines now attach result.output to the assertion message for diagnostics.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• CLI: Downgrade to Click 8.1, as the code is not compatible with 8.2 yet #435: Also modifies the Click dependency constraint and CHANGES.md entries — directly related to the dependency/version-range change.
• Anonymize sql statements #428: Adjusts the --anonymize option behavior in cratedb_toolkit/cfr/cli.py — directly related to the CLI change.
• CFR: Assorted fixes and improvements #483: Modifies tests/cfr/test_systable.py around CliRunner usage and stderr/stdout handling — related to the test changes.

Suggested reviewers

• hlcianfagna
• karynzv

Poem

🐰 I nudged a version door ajar,
Click widened, bright as morningstar.
A flag now points to decoder's name,
Tests now show output when they're to blame.
Little hops, big smiles — a carrot for the change!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main objective of the PR: expanding the click dependency constraint from <8.2 to <8.4 to permit click 8.3 installation.
Description check	✅ Passed	The description is related to the changeset, indicating an update to the click package with a reference to issue GH-628, which aligns with the dependency changes.
Docstring Coverage	✅ Passed	Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch click83

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}