Open
Conversation
4 tasks
Owner
Author
|
@daFish: Do you still see a need for this? |
craue
force-pushed
the
prepare-subtree-split-for-library-without-proxies
branch
from
28f6e7c to
8cd4149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #118. The idea is to keep everything in the bundle repo, but moving all files meant to be available for the library into a dedicated folder (which can then be used for a subtree split).
It still is a heavy BC break due to lots of namespace changes, so I'm not sure if it's worth it. I even tried replacing classes within the old namespaces by proxies, but that didn't work for all of them, so it's useless to do half-way.
The subtree split is available for testing - https://github.com/craue/CraueFormFlow - but don't rely on forward-only commits as the branch might be rewritten several times until this PR is eventually merged.