Skip to content

Fixed _onKeyPressed crashing on windows 11 with flutter 2.5 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Heinrich-vanNieuwenhuizen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed _onKeyPressed crashing on windows 11 with flutter 2.5 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lib/src/dropdown.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import 'dart:async';

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

import 'package:flutter/foundation.dart';

class DropdownEditingController<T> extends ChangeNotifier {
T? _value;
DropdownEditingController({T? value}) : _value = value;
Expand Down Expand Up @@ -129,7 +128,7 @@ class DropdownFormFieldState<T> extends State<DropdownFormField>
DropdownEditingController<dynamic>? get _effectiveController =>
widget.controller ?? _controller;

DropdownFormFieldState() : super() {}
DropdownFormFieldState() : super();

@override
void initState() {
Expand Down Expand Up @@ -366,34 +365,34 @@ class DropdownFormFieldState<T> extends State<DropdownFormField>
});
}

_onKeyPressed(RawKeyEvent event) {
KeyEventResult _onKeyPressed(RawKeyEvent event) {
// print('_onKeyPressed : ${event.character}');
if (event.isKeyPressed(LogicalKeyboardKey.enter)) {
if (_searchFocusNode.hasFocus) {
_toggleOverlay();
} else {
_toggleOverlay();
}
return false;
return KeyEventResult.skipRemainingHandlers;
} else if (event.isKeyPressed(LogicalKeyboardKey.escape)) {
_removeOverlay();
return true;
return KeyEventResult.handled;
} else if (event.isKeyPressed(LogicalKeyboardKey.arrowDown)) {
int v = _listItemFocusedPosition;
v++;
if (v >= _options!.length) v = 0;
_listItemFocusedPosition = v;
_listItemsValueNotifier.value = List<T>.from(_options ?? []);
return true;
return KeyEventResult.handled;
} else if (event.isKeyPressed(LogicalKeyboardKey.arrowUp)) {
int v = _listItemFocusedPosition;
v--;
if (v < 0) v = _options!.length - 1;
_listItemFocusedPosition = v;
_listItemsValueNotifier.value = List<T>.from(_options ?? []);
return true;
return KeyEventResult.handled;
}
return false;
return KeyEventResult.ignored;
}

_search(String str) async {
Expand Down