feat: support add groups for user#134
Conversation
| groups: | ||
| - group1:2000 | ||
| - group2:2001 |
There was a problem hiding this comment.
Would be better as a map:
| groups: | |
| - group1:2000 | |
| - group2:2001 | |
| groups: | |
| group1: 2000 | |
| group2: 2001 |
There was a problem hiding this comment.
Also I think we could deprecate group in favor of the new field.
There was a problem hiding this comment.
This is a good idea, I am trying to implement it.
|
Can you also add a new user with multiple groups in this file https://github.com/crazy-max/docker-samba/blob/master/test/data/config.yml so it's tested in ci workflow? |
auth:
- user: foo
group: foo
uid: 1000
gid: 1000
password: bar
groups: [qux, quux]
- user: yyy
group: xxx
uid: 1100
gid: 1200
password_file: /tmp/yyy_password
group:
qux: 2001
quux: 2002I think this is a better implementation because each user requires a main group. Additionally, this implementation can also ensure that groups are not created repeatedly. |
|
Nice one! You spared me a MR with a more clumsy implementation |
No description provided.