fix: HexInt.to_yaml crashes with TypeError when given an int#220
Open
gaoflow wants to merge 1 commit into
Open
fix: HexInt.to_yaml crashes with TypeError when given an int#220gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
HexInt.to_yaml() calls utils.is_hexadecimal(data) which performs a
regex match on the input. When data is a Python int, re.match()
raises TypeError since it requires a string.
Reorder the isinstance(data, int) check before the is_hexadecimal
call so int values are correctly serialized to hex strings like
"0xff", and non-string non-int values produce a clean
YAMLSerializationError instead of a TypeError crash.
Fixes round-trip: as_document({'x': 26}, Map({'x': HexInt()}))
now works instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HexInt.to_yaml() calls utils.is_hexadecimal(data) which performs a regex match on the input. When data is a Python int, re.match() raises TypeError since it requires a string.
Reorder the isinstance(data, int) check before the is_hexadecimal call so int values are correctly serialized to hex strings like "0xff", and non-string non-int values produce a clean YAMLSerializationError instead of a TypeError crash.
Fixes round-trip: as_document({'x': 26}, Map({'x': HexInt()})) now works instead of crashing.
AI disclosure: This PR was created using an AI assistant (Claude Code) under my direction. I reviewed the code, confirmed the bug, and validated the fix meets the project's standards.